Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npcap to 1.80 #476

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update npcap to 1.80 #476

merged 1 commit into from
Oct 15, 2024

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Oct 15, 2024

Updates npcap to version 1.80. I'm reading the docs about updating npcap, and I don't quite get this comment:

Make sure the PR adding this is back-ported to the Go versions required by the Packetbeat CrossBuild target in the mage file

Is the go version in .go-version. linked to golang-crossbuild in some way? Do I need to backport this PR to some version that matches the go version used by beats?

Copy link

mergify bot commented Oct 15, 2024

This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link

💚 Build Succeeded

cc @fearful-symmetry

@elasticmachine
Copy link

💚 Build Succeeded

cc @fearful-symmetry

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 15, 2024
@elasticmachine
Copy link

💚 Build Succeeded

cc @fearful-symmetry

@cmacknz
Copy link
Member

cmacknz commented Oct 15, 2024

Is the go version in .go-version. linked to golang-crossbuild in some way? Do I need to backport this PR to some version that matches the go version used by beats?

Yes there is a crossbuild container release per Go version https://github.com/elastic/golang-crossbuild/releases. The main branch is the current Go minor (1.23) and there is a branch for each previous one (1.22, 1.19, etc.)

@cmacknz
Copy link
Member

cmacknz commented Oct 15, 2024

When you merge this without backporting I thin it will only be usable for repositories that build with Go 1.23.

@fearful-symmetry fearful-symmetry added backport-v1.22 Automated label to backport with Mergify and removed backport-skip labels Oct 15, 2024
@fearful-symmetry
Copy link
Contributor Author

@cmacknz alright, added the backport label, we should be good?

@cmacknz
Copy link
Member

cmacknz commented Oct 15, 2024

I think so, I am not 100% sure what happens to the container tags, the best outcome is they are republished with the npcap version bumped. You'll have to watch for that.

@fearful-symmetry fearful-symmetry merged commit 40bab45 into main Oct 15, 2024
10 checks passed
@fearful-symmetry fearful-symmetry deleted the npcap_update branch October 15, 2024 18:15
mergify bot pushed a commit that referenced this pull request Oct 15, 2024
(cherry picked from commit 40bab45)
@fearful-symmetry
Copy link
Contributor Author

@Mergifyio backport 1.22.8.x

Copy link

mergify bot commented Oct 15, 2024

backport 1.22.8.x

✅ Backports have been created

  • Backport to branch 1.22.8.x not needed, change already in branch 1.22.8.x

fearful-symmetry added a commit that referenced this pull request Oct 16, 2024
@v1v
Copy link
Member

v1v commented Oct 28, 2024

I think so, I am not 100% sure what happens to the container tags, the best outcome is they are republished with the npcap version bumped. You'll have to watch for that.

https://github.com/elastic/golang-crossbuild/blob/main/NPCAP.md explains the steps that are required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v1.22 Automated label to backport with Mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants