Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cisco] Make event.original optional #1073

Merged
merged 1 commit into from
Jun 3, 2021
Merged

[cisco] Make event.original optional #1073

merged 1 commit into from
Jun 3, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 3, 2021 •
edited
Loading

What does this PR do?

  • Makes event.original optional
  • Updates README with sample events.
  • Unifies pipeline tests configs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Screenshots

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr force-pushed the cisco-event-original branch from fa7dedc to 3df667c Compare June 3, 2021 07:37
@marc-gr marc-gr mentioned this pull request Jun 3, 2021
Closed
43 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 3, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1073 updated

  • Start Time: 2021-06-03T09:33:52.244+0000

  • Duration: 30 min 35 sec

  • Commit: c5cb220

Test stats 🧪

Test Results
Failed 0
Passed 59
Skipped 0
Total 59

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr marc-gr force-pushed the cisco-event-original branch from 3df667c to b3cb0a6 Compare June 3, 2021 08:16
@marc-gr marc-gr force-pushed the cisco-event-original branch from b3cb0a6 to c5cb220 Compare June 3, 2021 09:33
@marc-gr marc-gr changed the title [cisco] Make event.original optional for asa,ftd, and ios data streams. [cisco] Make event.original optional Jun 3, 2021
P1llus
P1llus approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit b109fee into elastic:master Jun 3, 2021
@marc-gr marc-gr deleted the cisco-event-original branch June 3, 2021 14:21
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
Make event.original optional for asa,ftd, and ios data streams. (elas…
046793a 
…tic#1073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @P1llus