Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] add back compatibility to 7.17 track #3755

Merged
merged 1 commit into from
Jul 20, 2022
Merged

[GCP] add back compatibility to 7.17 track #3755

merged 1 commit into from
Jul 20, 2022

Conversation

endorama
Copy link
Member

What does this PR do?

As elastic/kibana#136289 has been merged we can re add compatibility for this package to 7.17 track.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@endorama
re-add 7.17 compatibility
16dc9e5 
As elastic/kibana#136289 has been merged
we can re add compatibility for this package to 7.17 track.

Closes #3714
@endorama endorama requested review from a team as code owners July 19, 2022 12:45
@endorama endorama added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jul 19, 2022
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-19T12:45:42.440+0000

  • Duration: 20 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.043
Classes 100.0% (4/4) 💚 3.043
Methods 93.939% (62/66) 👍 4.859
Lines 95.969% (1119/1166) 👍 5.796
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh mentioned this pull request Jul 19, 2022
Closed
tommyers-elastic
tommyers-elastic approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endorama
Copy link
Member Author

Thank you all!

@endorama endorama merged commit 2b14e48 into elastic:main Jul 20, 2022
@endorama endorama deleted the gcp-7.17-compat branch July 20, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GCP] Re introduce compatibility with 7.17
4 participants
@endorama @elasticmachine @andrewkroh @tommyers-elastic