New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Replace deprecated EuiFilterSelectItem with EuiSelectable #162766

Closed

juliaElastic opened this issue Jul 31, 2023 · 1 comment · Fixed by #175101

Assignees

Labels

Team:Fleet

Contributor

juliaElastic commented Jul 31, 2023

Due to changes in EUI, EuiFilterSelectItem is deprecated and should be replaced with EuiSelectable.
See usages here:
https://github.com/elastic/kibana/pull/162660/files?file-filters%5B%5D=.json&file-filters%5B%5D=.lock&file-filters%5B%5D=.snap&file-filters%5B%5D=.ts&file-filters%5B%5D=.tsx&owned-by%5B%5D=juliaElastic&show-viewed-files=true

The text was updated successfully, but these errors were encountered:

juliaElastic added the Team:Fleet label

Contributor

elasticmachine commented Jul 31, 2023

Pinging @elastic/fleet (Team:Fleet)

juliaElastic self-assigned this

juliaElastic mentioned this issue

[Fleet] replace EuiFilterSelectItem with EuiSelectable #175101

Merged

2 tasks

juliaElastic closed this as completed in #175101

juliaElastic added a commit that referenced this issue


          [Fleet] replace EuiFilterSelectItem with EuiSelectable (#175101)

f77542c

## Summary

Closes #162766

Replace deprecated EUI component.

Agent details: select log level

<img width="1302" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/2ab0cd2c-38f3-4219-9ea2-62dfaa3a8e99">

Agent details: select dataset

<img width="1387" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/4187c274-e035-4831-9d9d-87c87a3ff9c3">

Agent status filter:
<img width="1251" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/15e226a2-cc10-4b43-881f-923fe03364f5">

Agent list view:
Agent policy select:
<img width="461" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/4f0f697c-af33-4934-92ef-e9a8e16bf1ed">

Tags select:
<img width="280" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/0be8719e-cf4b-4a1d-a4c6-c04090f72600">



### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue


          [Fleet] replace EuiFilterSelectItem with EuiSelectable (elastic#175101)

090e109

## Summary

Closes elastic#162766

Replace deprecated EUI component.

Agent details: select log level

<img width="1302" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/2ab0cd2c-38f3-4219-9ea2-62dfaa3a8e99">

Agent details: select dataset

<img width="1387" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/4187c274-e035-4831-9d9d-87c87a3ff9c3">

Agent status filter:
<img width="1251" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/15e226a2-cc10-4b43-881f-923fe03364f5">

Agent list view:
Agent policy select:
<img width="461" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/4f0f697c-af33-4934-92ef-e9a8e16bf1ed">

Tags select:
<img width="280" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/0be8719e-cf4b-4a1d-a4c6-c04090f72600">



### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment