[OneDiscover][Security Solution] Refactor Security components to use rowAdditionalLeadingControls prop for UnifiedDataTable
#189294
Labels
Project:OneDiscover
Enrich Discover with contextual awareness
Team:Security Solution Platform
Security Solution Platform Team
Team:Threat Hunting:Investigations
Security Solution Investigations Team
Comments
10 tasks
dmlemeshko
added
the
Team:Security Solution Platform
|
Pinging @elastic/security-detection-engine (Team:Security Solution Platform) |
logeekal
added
the
Team:Threat Hunting:Investigations
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
jughosta
added a commit
that referenced
this issue
Aug 7, 2024
- Closes #186637 - Closes #186808 ## Summary - [x] Extend UnifiedDataTable with a new `rowAdditionalLeadingControls` prop to render additional leading controls - [x] In case of many actions, collapse the rest of them under "More" button - [x] New OneDiscover extension - [x] Convert from `customControlColumnsConfiguration` to the new prop. Refactor actions format in Log Explorer. - [x] Swap the default "select" and "expand" control columns ~if custom row actions are specified~ - [x] Add to example OneDiscover profile - [x] Add functional and units tests <img width="858" alt="Screenshot 2024-07-26 at 16 00 17" src="https://github.com/user-attachments/assets/68832abc-a498-4ec6-8333-79ad5f83855b"> <img width="1139" alt="Screenshot 2024-07-26 at 16 00 47" src="https://github.com/user-attachments/assets/8ff99ac1-21b0-4687-b548-fbf3c5517808"> ### Testing For testing the example profile: - add `discover.experimental.enabledProfiles: ['example-root-profile', 'example-data-source-profile', 'example-document-profile']` to kibana.dev.yml - start kibana - make sure to have an index with `my-example-logs` name or create an alias to an existing index: ``` POST _aliases { "actions": [ { "add": { "index": "kibana_sample_data_logs", "alias": "my-example-logs" } } ] } ``` - create a data view for `my-example-logs` index ### Follow up for Security solution The following items would require deprecation/refactoring in components on Security Solution pages to have consistent UX (can result in 500+ lines of code changes): - Convert from `externalControlColumns` to the new prop `rowAdditionalLeadingControls` - Convert from `trailingControlColumns` to a normal column. `trailingControlColumns` is deprecated. - #189294 - Use `getRowIndicator` prop on UnifiedDataTable instead of `border-left` style - #189295 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow up for:
We suggest to refactor the code to use the new prop
rowAdditionalLeadingControlswhich provides a unified look for row leading controls (can result in 500+ lines of code changes):externalControlColumnsto the new proprowAdditionalLeadingControlsConvert fromtrailingControlColumnsto a normal column.trailingControlColumnsprop is deprecatedThe text was updated successfully, but these errors were encountered: