-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shared-ux] Migrate solution toolbar button #125998
[shared-ux] Migrate solution toolbar button #125998
Conversation
@elasticmachine merge upstream |
… into migrate-solution-toolbar-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, two minor comments
src/plugins/shared_ux/public/components/toolbar/solution_toolbar/button/primary.stories.tsx
Outdated
Show resolved
Hide resolved
… into migrate-solution-toolbar-button
Great work! |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Breaking #124372 into smaller PRs.
This PR adds mdx documentation, a storybook example and tests for the primary button within the solution toolbar. This PR is intended to be a starting point for future PRs to build out other solution toolbar components.
The primary button component has been edited to contain the required prop of a
label
and optional props ofonClick
andiconType
. IconSide has been set to the left based on current implementations.Current implementations:
add from library
andpopover
Added storybook example:
Checklist
Delete any items that are not applicable to this PR.
For maintainers