Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shared-ux] Migrate solution toolbar quick group buttons as icon button group component #126297

Merged
merged 56 commits into from
Mar 16, 2022
Merged

[shared-ux] Migrate solution toolbar quick group buttons as icon button group component #126297

merged 56 commits into from
Mar 16, 2022

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Feb 23, 2022 •
edited
Loading

Summary

This PR migrates the solution toolbar quick buttons from the presentation team to the shared UX team.

The quick group buttons are currently used here:

  • solution toolbar within presentation
  • dashboard_top_nav.tsx in the dashboard
  • workpad_header.component.tsx within canvas

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rshen91 rshen91 added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes loe:medium Medium Level of Effort v8.2.0 labels Feb 23, 2022
@rshen91 rshen91 mentioned this pull request Mar 2, 2022
Open
15 tasks
@rshen91 rshen91 self-assigned this Mar 4, 2022
@rshen91 rshen91 marked this pull request as ready for review March 4, 2022 18:53
@rshen91 rshen91 changed the title [shared-ux] Migrate solution toolbar quick group buttons [shared-ux] Migrate solution toolbar quick group buttons as icon button group component Mar 14, 2022
sebelga
sebelga reviewed Mar 15, 2022
View reviewed changes
...ins/shared_ux/public/components/toolbar/buttons/icon_button_group/icon_button_group.test.tsx Outdated
enzymeMount(<ServicesProvider {...services}>{element}</ServicesProvider>);
});

afterEach(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this necessary? I am not seeing any jest mock being set in this test file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Removed it in bbd09df thank you!

@rshen91 rshen91 requested a review from sebelga March 15, 2022 15:13
cchaos
cchaos suggested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few last/missed Quick -> Icon changes and removing more "Solution" text

@rshen91 rshen91 requested a review from cchaos March 15, 2022 18:29
@rshen91 rshen91 requested a review from cchaos March 15, 2022 20:32
@rshen91 rshen91 enabled auto-merge (squash) March 16, 2022 14:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
sharedUX 59 61 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sharedUX 102.1KB 102.9KB +858.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
sharedUX 5.4KB 5.5KB +149.0B
Unknown metric groups

API count

id before after diff
sharedUX 14 16 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

@rshen91 rshen91 merged commit f5daf2f into elastic:main Mar 16, 2022
@rshen91 rshen91 deleted the migrate-quick-group branch March 16, 2022 17:17
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@rshen91 @maksimkovalev
[shared-ux] Migrate solution toolbar quick group buttons as icon butt…
d846ece 
…on group component (elastic#126297)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majagrubic majagrubic majagrubic approved these changes

@clintandrewhall clintandrewhall clintandrewhall approved these changes

@cchaos cchaos cchaos approved these changes

@sebelga sebelga Awaiting requested review from sebelga

Assignees

@rshen91 rshen91

Labels
backport:skip This commit does not require backporting loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rshen91 @cchaos @kibana-ci @clintandrewhall @majagrubic @sebelga