Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover Tabs] Support renaming tabs via double click #213540

Merged
merged 8 commits into from
Mar 10, 2025
Merged

[Discover Tabs] Support renaming tabs via double click #213540

merged 8 commits into from
Mar 10, 2025
+312 −48

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Mar 7, 2025 •
edited
Loading

Summary

This PR enables tab label editing by adding double click handling.

Mar-07-2025 12-01-53

Testing

Two options are possible:

  1. start Storybook with yarn storybook unified_tabs and navigate to http://localhost:9001.
  2. start Kibana with yarn start --run-examples. Then navigate to the Unified Tabs example plugin http://localhost:5601/app/unifiedTabsExamples.

Checklist

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Project:OneDiscover Enrich Discover with contextual awareness labels Mar 7, 2025
@jughosta jughosta self-assigned this Mar 7, 2025
@jughosta jughosta mentioned this pull request Mar 7, 2025
Closed
10 tasks
@jughosta jughosta marked this pull request as ready for review March 7, 2025 13:47
@jughosta jughosta requested a review from a team as a code owner March 7, 2025 13:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta
Copy link
Contributor Author

jughosta commented Mar 7, 2025

The last build succeeded but did not report back to Github for some reason https://buildkite.com/elastic/kibana-pull-request/builds/281753 so I triggered another one.

akowalska622
akowalska622 reviewed Mar 10, 2025
View reviewed changes
src/platform/packages/shared/kbn-unified-tabs/src/components/tab/edit_tab_label.tsx Outdated
Comment on lines 16 to 17
block-size: 28px;
margin-top: 4px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use euiTheme.size here?

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @jughosta

@jughosta jughosta merged commit 250a473 into elastic:main Mar 10, 2025
10 checks passed
@jughosta jughosta deleted the 210509-allow-to-edit-tab-label branch March 10, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akowalska622 akowalska622 akowalska622 approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting Project:OneDiscover Enrich Discover with contextual awareness release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover Session][Tabs] Support renaming tabs
4 participants
@jughosta @elasticmachine @akowalska622 @kibanamachine