Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Home][Tutorial] Add STAN data UI #54102

Merged
merged 4 commits into from
Jan 10, 2020
Merged

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 7, 2020

Signed-off-by: ChrsMark [email protected]

Summary

This PR adds data ui for STAN Metricbeat Module.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

Screenshot 2020-01-07 at 16 40 06

Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 7, 2020
@ChrsMark ChrsMark requested a review from a team January 7, 2020 11:25
@ChrsMark ChrsMark self-assigned this Jan 7, 2020
@ChrsMark
Copy link
Member Author

ChrsMark commented Jan 8, 2020

@kertal since you reviewed the very similar one last time, could you please have a look to this too? :)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be the screenshot file missing. Furthermore, could you prefix the title of this PR with [Home][Tutorial] Then it would be clear which part of Kibana is modified with just a single look Thx a lot 👍

},
},
completionTimeMinutes: 10,
previewImagePath: '/plugins/kibana/home/tutorial_resources/stan_metrics/screenshot.png',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is missing?

@kertal kertal added the Feature:Home Kibana home application label Jan 9, 2020
@@ -0,0 +1,102 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, since SVGs aren't automatically minified by Kibana when loaded like this, could you please minify this SVG manually (at least let's remove, the tons of inkscape, sodipodi tags and metadata tags in it), but ideally run it through something like SVGO, please.

@ChrsMark ChrsMark changed the title Add STAN data UI [Home][Tutorial] Add STAN data UI Jan 9, 2020
@ChrsMark
Copy link
Member Author

ChrsMark commented Jan 9, 2020

Thank you so much for reviewing folks!

@kertal sorry for the missing file, it should be commented out actually since the dashboard is not ready yet. I also changed the tittle of the PR accordingly.

@timroes good to know about the svg optimisation, I passed it through https://github.com/svg/svgo, hope it is good now.

@kertal
Copy link
Member

kertal commented Jan 9, 2020

@elasticmachine merge upstream

@kertal kertal self-requested a review January 9, 2020 16:42
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thx for cleaning up and minifying the SVG!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Home Kibana home application release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants