-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding kafka output support #33
Conversation
Adding some tests as well now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait for the GH actions to run. Currently there are no checks on the last commit and I assume it's because of issues with GH infrastructure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry.
Tested this with a local Kafka instance:
Start Kafka:
docker run -p 9092:9092 -d bashj79/kafka-kraft
Send data:
Double check that data is actually stored in topic:
While I could add in more options, currently it supports only Topic. We don't need things like groups etc, as we are not consuming but simply creating the topic and its data.
If you would like me to add more debugging output or similar, just let me know, but I feel that for stream this should be sufficient.