Add exit-on-unmatched-rule option for http server
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-gr
force-pushed
the
exit-on-unmatched-rule
branch
from
b59d414 to
20e61d1
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
P1llus
approved these changes
Nov 7, 2023
andrewkroh
reviewed
Nov 7, 2023
| handler, err := newHandlerFromConfig(config, logger) | ||
| notFoundHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| logger.Debugf("request did not match with any rule: %s", strRequest(r)) | ||
| w.WriteHeader(404) |
There was a problem hiding this comment.
I think there is an http.NotFound constant.
| logger.Debugf("request did not match with any rule: %s", strRequest(r)) | ||
| w.WriteHeader(404) | ||
| if opts.ExitOnUnmatchedRule { | ||
| logger.Fatalf("--exit-on-unmatched-rule is set, exiting") |
There was a problem hiding this comment.
I think it would be more graceful to asynchronously stop the server. With os.Exit being called from the handler there is no guarantee that the response has been flushed to the client before the program stops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61