Docker image #48
Docker image #48
Conversation
| tar -xf node.tar.gz && \ | ||
| mv node-v* node | ||
| ENV PATH="/usr/share/heartbeat/.node/node/bin:$PATH" | ||
| RUN npm i -g playwright |
There was a problem hiding this comment.
we might have to find a way to skip firefox, webkit installation. take up memory and time.
There was a problem hiding this comment.
@vigneshshanmugam I tried installing the playwright-chromium package, which does exactly that, but it caused weird issues, and running our stuff still asked for playwright. Something to figure out before GA for sure.
There was a problem hiding this comment.
Two options i see from this thread - microsoft/playwright#823
If we are going via playwright-chromium, then we have to use the playwright-core in our code to avoid downloading multiple times.
There is also a programmatic way of downloading browsers.
const {chromium} = require('playwright');
chromium. downloadBrowserIfNeeded()We could do this in post-install script of our library
There was a problem hiding this comment.
Lets solve in separate PR.
Dockerfile
Outdated
| ENV PATH="/usr/share/heartbeat/.node/node/bin:$PATH" | ||
| RUN npm i -g playwright | ||
| COPY elastic-synthetics*.tgz /opt/elastic-synthetics.tgz | ||
| RUN npm install -g /opt/elastic-synthetics.tgz |
There was a problem hiding this comment.
any specific reason for using packed file vs directly installing our package?
There was a problem hiding this comment.
alternatively we can copy /src into the image and install the dependencies during the docker build.
There was a problem hiding this comment.
Yeah, I tried doing exactly that, which I realize is more standard, but I hit some weird error during the build IIRC, this worked reliably
There was a problem hiding this comment.
Think, we have to copy /dist not source.
There was a problem hiding this comment.
Oh, I remember what the problem is now. Running npm i /path/to/repo doesn't actually 'install' the package, it really just links it. For some reason on the docker image this wasn't working. Doing a 'proper' pack and install made it act like other node modules.
This probably has some other advantages in that when it comes to release time I assume we'll actually run the npm packed version instead of direct from source, so this makes it more similar. That said, IMHO both methods are fine.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
| USER root | ||
| RUN yum -y update && \ | ||
| yum -y install epel-release && \ | ||
| yum -y localinstall --nogpgcheck https://download1.rpmfusion.org/free/el/rpmfusion-free-release-7.noarch.rpm && \ |
There was a problem hiding this comment.
I added this for ffmpeg, but I need to see if we really need this, since it's not on the official package list playwright recommends for centos.
| @@ -0,0 +1,24 @@ | |||
| FROM docker.elastic.co/beats/heartbeat:8.0.0 | |||
There was a problem hiding this comment.
Should be changed to version 7.10.0-SNAPSHOT
There was a problem hiding this comment.
Let's make that change on the 7.x branch when we create it
| heartbeat.monitors: | ||
| - type: browser | ||
| id: my-monitor | ||
| name: My Monitor |
There was a problem hiding this comment.
we can do it separate PR as well, let's add the path which is also supported?
Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Co-authored-by: Ivan Fernandez Calvo <[email protected]>
This requires that your system already have the docker image
docker.elastic.co/beats/heartbeat:8.0.0, which at the moment must be created off of this branch. To build itcd x-pack/heartbeat && env PLATFORMS=linux/amd64 mage package.