Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a developer, I would like a config directory, along with config setting files. #45

Closed
4 of 9 tasks
Bowens20832 opened this issue May 28, 2023 · 1 comment · Fixed by #50
Closed
4 of 9 tasks

As a developer, I would like a config directory, along with config setting files. #45

Bowens20832 opened this issue May 28, 2023 · 1 comment · Fixed by #50
Assignees
@Bowens20832
Labels
status: in progress This topic is in development progress and will be included in the tagged version. status: ready to merge PR's that are ready for public review and comment. Will be merged in a matter of days once tagged. type: bug Issues that need priority attention. type: enhancement New feature or request. type: friction Elegant user friction. To be fixed with priority.
Milestone
Elegant version 2...

Comments

@Bowens20832
Copy link
Contributor

Bowens20832 commented May 28, 2023 •
edited
Loading

As a developer, I would like a seperate /config directory under the root project. This config folder will serve as the center off all Elegant app configuration.

This directory, and the config files contained within it will serve as the bootstrap point for all config values set within .env files.

  • Create /config folder
  • Create app.ts file
  • Create navigation.ts file
  • Create authors type
  • Create authors.ts file
  • Update any existing process.env vars to use new config code.
  • Refactor out the App config code from the utils folder.
  • Migrate exisiting navigation config code to the config folder, from the navs folder
  • Delete navs folder
@Bowens20832 Bowens20832 added type: bug Issues that need priority attention. type: enhancement New feature or request. type: friction Elegant user friction. To be fixed with priority. status: in progress This topic is in development progress and will be included in the tagged version. labels May 28, 2023
@Bowens20832 Bowens20832 self-assigned this May 28, 2023
Bowens20832 added a commit that referenced this issue May 30, 2023
@Bowens20832
Created a simple Config namespace and utility function.
3f3793e 
Created a /config namespace. Resolves #45

Users can now call Config('app.name') to load the app name. If .env file is not present, instead of crashing during build, it will read from our base config code.
@Bowens20832 Bowens20832 linked a pull request May 31, 2023 that will close this issue
Feature/app config #50
Merged
@Bowens20832 Bowens20832 added the status: ready to merge PR's that are ready for public review and comment. Will be merged in a matter of days once tagged. label Jun 1, 2023
Bowens20832 added a commit that referenced this issue Jun 2, 2023
@Bowens20832
Feature/app config (#50)
bd449ef 
* Created a simple Config namespace and utility function.

Created a /config namespace. Resolves #45

Users can now call Config('app.name') to load the app name. If .env file is not present, instead of crashing during build, it will read from our base config code.

* Completed App config.

Completed the application config code.

- Also updated the .env logic for app type.

* Completed the base app config.

- Completed the base app config.
- Updated existing env vars to use new Config method.
- Refactored AppInfo to now just be call App.ts under the config namespace.

* Updated components to use the new Config namespace, instead of process.env

* Work in progress

* Fixed the broken GitHub link in the docs footer.

Fixed the broken GitHub link in the docs footer. Also set that link to pop open in a new window.

* Update ContentsLayout.js

Made the GitHub link in the docs footer dynamic. If no GitHub repo is present in the .env file, it will not show the Edit link.

* Update _app.js

Converted env vars to the new config namespace.

* Update App.test.ts

* Completed the App config

* 2.2.2-innovators.13

* Fix GitIgnore

* 2.2.2-innovators.14

* Trademark policy quick fixes

* Legal Page layout fixes

* Update LegalPageLayout.js

* 2.2.2-innovators.15
@Bowens20832
Copy link
Contributor Author

Resolved by #50.. Closing this ticket in favor of an updated #59 .. This allows the v2.2 release to continue down the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bowens20832 Bowens20832

Labels
status: in progress This topic is in development progress and will be included in the tagged version. status: ready to merge PR's that are ready for public review and comment. Will be merged in a matter of days once tagged. type: bug Issues that need priority attention. type: enhancement New feature or request. type: friction Elegant user friction. To be fixed with priority.
Projects
None yet
Milestone
Elegant version 2.2 - Stable Release
Development

Successfully merging a pull request may close this issue.

Feature/app config elegantframework/elegant-cli
1 participant
@Bowens20832