the navigation and authors config to be under the '/config' namespace #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bowens20832
added
type: enhancement
4 tasks
This reverts commit 88084d1.
Bowens20832
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
I think you merged you code from #81 into this branch as well.
I have moved that code into it's own feature branch and will open a PR and review it for you 😄
Thank you for the code contribution!
Bowens20832
approved these changes
Jul 3, 2023
Bowens20832
approved these changes
Jul 5, 2023
Bowens20832
approved these changes
Jul 6, 2023
- Updated Authors.ts to match existing naming style convention. - Updated Navigation.ts to match existing naming style convention. - Migrated and deleted depreacted authors.js file. - Wrote Jest test for new Authors.ts file. - Updated package-lock.json file. Ready for production use. Thanks @Shiv-2712 for the contribution! 😄 Co-Authored-By: Shiv Kumar Saxena <[email protected]>
Bowens20832
added
version: 2.3
status: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have added navigation.ts and authors.ts under ./config folder and added the sample code.