Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/video layout #116

Merged

Conversation

Armaan-Singh-Dhillon
Copy link
Contributor

Fixed video layout by setting width in percentage

@Bowens20832 Bowens20832 self-assigned this Jul 7, 2023
@Bowens20832 Bowens20832 added type: bug Issues that need priority attention. type: friction Elegant user friction. To be fixed with priority. version: 2.3 status: waiting review Pull Requests that are waiting for review by an Elegant maintainer. labels Jul 7, 2023
Copy link
Contributor

@Bowens20832 Bowens20832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thank you @Armaan-Singh-Dhillon for the help and contribution! 😎

@Bowens20832 Bowens20832 added status: ready to merge PR's that are ready for public review and comment. Will be merged in a matter of days once tagged. and removed status: waiting review Pull Requests that are waiting for review by an Elegant maintainer. labels Jul 7, 2023
@Bowens20832 Bowens20832 merged commit 98c002e into elegantframework:v2.3 Jul 8, 2023
@Armaan-Singh-Dhillon Armaan-Singh-Dhillon deleted the bugfix/videoLayout branch July 8, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge PR's that are ready for public review and comment. Will be merged in a matter of days once tagged. type: bug Issues that need priority attention. type: friction Elegant user friction. To be fixed with priority.
Projects
Status: Elegant - version 2.3
Development

Successfully merging this pull request may close these issues.

The Video component breaks the layout of the documentation on mobile.
2 participants