Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for Avatar and IconButton components #66

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

germain-gg
Copy link
Contributor

Fixes element-hq/element-web#26055

  • Remove hover state of disabled icon buttons
  • Remove ID as the title of the avatar component by default

@germain-gg germain-gg requested a review from a team as a code owner August 31, 2023 19:53
@germain-gg germain-gg requested review from t3chguy and kerryarchibald and removed request for a team August 31, 2023 19:53
@robintown
Copy link
Member

I'm confused by why the avatar title change is included here as well. It seems unrelated?

@germain-gg germain-gg changed the title Remove hover state of disabled icon buttons Bugfixes for Avatar and IconButton components Aug 31, 2023
@germain-gg
Copy link
Contributor Author

@robintown Woops, sorry about that, i've bundled two bugfixes and did not add a useful title to this pull request.
Hopefully we can land that and fix two birds with one stone

Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@germain-gg germain-gg merged commit 0682d6a into main Sep 1, 2023
@germain-gg germain-gg deleted the germain-gg/ui-fixes branch September 1, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hovering over a room avatar shows the room ID in a tooltip
3 participants