Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pills for permalink supported hosts #8324

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Apr 11, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

#8307

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from giomfo, a team and jmartinesp and removed request for a team April 11, 2023 09:47
@yostyle yostyle force-pushed the yostyle/fix_permalink_supported_hosts branch 2 times, most recently from 377b1dc to 2f7d862 Compare April 11, 2023 09:56
@yostyle yostyle force-pushed the yostyle/fix_permalink_supported_hosts branch from 2f7d862 to 7fc43e5 Compare April 12, 2023 07:28
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the tests seem to need a fix to pass.

@yostyle yostyle enabled auto-merge (squash) April 12, 2023 11:57
@yostyle yostyle disabled auto-merge April 12, 2023 11:58
@yostyle
Copy link
Contributor Author

yostyle commented Apr 12, 2023

LGTM, although the tests seem to need a fix to pass.

Yes I fix them in my last commit.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle enabled auto-merge (squash) April 12, 2023 12:08
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yostyle yostyle merged commit 110b5cf into develop Apr 12, 2023
@yostyle yostyle deleted the yostyle/fix_permalink_supported_hosts branch April 12, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants