Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embedding of the Element Call assets within a widget host #2994

Open
hughns opened this issue Feb 6, 2025 · 1 comment
Open

Support embedding of the Element Call assets within a widget host #2994

hughns opened this issue Feb 6, 2025 · 1 comment
Assignees
@hughns
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@hughns
Copy link
Member

hughns commented Feb 6, 2025 •
edited
Loading

This only needs to support Element Call running as a widget (not standalone).

Specific scenarios that we want to support:

  • a npm package for consumption in a web application such as Element Web
  • a Maven package for consumption in an Android app such as Element X Android
  • a SwiftPM package for consumption in an iOS app such as Element X iOS

Pull requests:
@hughns hughns added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 6, 2025
This was referenced Feb 6, 2025
Merged
Merged
@hughns hughns self-assigned this Feb 6, 2025
@hughns hughns mentioned this issue Feb 7, 2025
Merged
@hughns hughns mentioned this issue Feb 18, 2025
Closed
@hughns
Copy link
Member Author

hughns commented Feb 18, 2025

Work in progress is visible at livekit...hughns:element-call:publishing

@robintown robintown mentioned this issue Feb 24, 2025
Merged
hughns added a commit to hughns/element-call that referenced this issue Mar 10, 2025
@hughns
Use fetch() in a way that works for file URLs
835ebb9 
fetch returns a response code of 0 when it successfully loads a `file://` resource.

This means we can't just rely on `response.ok`.

Required for element-hq#2994
This was referenced Mar 10, 2025
Merged
Open
Draft
Merged
Draft
hughns added a commit that referenced this issue Mar 11, 2025
@hughns
Use fetch() in a way that works for file URLs (#3071)
1a692b9 
fetch returns a response code of 0 when it successfully loads a `file://` resource.

This means we can't just rely on `response.ok`.

Required for #2994
hughns added a commit to hughns/element-call that referenced this issue Mar 11, 2025
@hughns
Use fetch() in a way that works for file URLs
06254f9 
fetch returns a response code of 0 when it successfully loads a `file://` resource.

This means we can't just rely on `response.ok`.

Required for element-hq#2994
hughns added a commit to hughns/element-call that referenced this issue Mar 11, 2025
@hughns
Embedded package build of Element Call
37f0574 
Part of element-hq#2994

This creates a new "embedded" build (vs "full" build) at the vite level. It will be used by a later PR that actually provides platform specific packages.

Embedded build:

- Uses relative URLs
- Uses relative config.json path and other resource loading
- Has a config.json built in
- Doesn't include the public folder (e.g. favicon)

Out of scope:

- this doesn't attempt to exclude SPA functionality, so technically the build could be used in SPA
- the above means that the crypto-wasm binary is included in the build
@hughns hughns mentioned this issue Mar 11, 2025
Merged
hughns added a commit to hughns/element-call that referenced this issue Mar 12, 2025
@hughns
Embedded package build of Element Call
18b05b3 
Part of element-hq#2994

This creates a new "embedded" build (vs "full" build) at the vite level. It will be used by a later PR that actually provides platform specific packages.

Embedded build:

- Uses relative URLs
- Uses relative config.json path and other resource loading
- Has a config.json built in
- Doesn't include the public folder (e.g. favicon)

Out of scope:

- this doesn't attempt to exclude SPA functionality, so technically the build could be used in SPA
- the above means that the crypto-wasm binary is included in the build
This was referenced Mar 12, 2025
Open
Open
hughns added a commit that referenced this issue Mar 12, 2025
@hughns
Vite embedded build of Element Call (#3077)
7aac56a 
* Embedded package build of Element Call

Part of #2994

This creates a new "embedded" build (vs "full" build) at the vite level. It will be used by a later PR that actually provides platform specific packages.

Embedded build:

- Uses relative URLs
- Uses relative config.json path and other resource loading
- Has a config.json built in
- Doesn't include the public folder (e.g. favicon)

Out of scope:

- this doesn't attempt to exclude SPA functionality, so technically the build could be used in SPA
- the above means that the crypto-wasm binary is included in the build

* CI artifact name based on type of build

* Update src/config/Config.ts
hughns added a commit to hughns/element-call that referenced this issue Mar 12, 2025
@hughns
Embedded package build of Element Call
8c63747 
Part of element-hq#2994

This PR:

- Publishes embedded builds as Tarball, NPM, AAR, SwiftPM for releases
- Publishes full builds as Tarball for releases
- Adds comments to release notes with the built artifact locations
@hughns hughns mentioned this issue Mar 12, 2025
Closed
hughns added a commit that referenced this issue Mar 12, 2025
@hughns
Publish embedded package for releases of Element Call
8b2c4de 
Part of #2994

This PR:

- Publishes embedded builds as Tarball, NPM, AAR, SwiftPM for releases
- Publishes full builds as Tarball for releases
- Adds comments to release notes with the built artifact locations
This was referenced Mar 12, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hughns hughns

Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hughns