Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure call sound effects are played over the correct sink #2863

Merged
merged 31 commits into from
Dec 9, 2024
Merged

Ensure call sound effects are played over the correct sink #2863

merged 31 commits into from
Dec 9, 2024

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Dec 3, 2024 •
edited
Loading

This PR refactors much of the work I did on sound effects to make them play over an AudioContext instead, which let's us pick a preferred sync.

To fix:

  • Join/leave sounds
  • Hand raised sounds
  • Reaction sounds

@Half-Shot Half-Shot mentioned this pull request Dec 3, 2024
Merged
Half-Shot
Half-Shot commented Dec 4, 2024
View reviewed changes
src/useAudioContext.test.tsx Outdated

/**
* Test explanation.
* This test suite checks that the useReactions hook appropriately reacts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong

Half-Shot
Half-Shot commented Dec 4, 2024
View reviewed changes
src/useAudioContext.tsx Outdated

type PrefetchedSounds<S extends string> = Promise<Record<S, ArrayBuffer>>;

// We prefer to load these sounds ahead of time, so there
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong comment?

@Half-Shot Half-Shot marked this pull request as ready for review December 5, 2024 10:15
@Half-Shot Half-Shot requested a review from a team as a code owner December 5, 2024 10:15
@Half-Shot Half-Shot requested a review from hughns December 5, 2024 10:15
@Half-Shot Half-Shot requested a review from hughns December 6, 2024 16:44
hughns
hughns requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the direction of the abstraction that the refactor has taken. 👍

A few questions and clean up needed.

@Half-Shot Half-Shot requested a review from hughns December 9, 2024 09:51
hughns
hughns approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a settings wording tweak. But now looks good 👍

@Half-Shot Half-Shot merged commit a8a95c3 into livekit Dec 9, 2024
7 checks passed
@fkwp fkwp mentioned this pull request Mar 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughns hughns hughns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @hughns