Devex: Default vite config to support using local build of crypto wasm #3038
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
approved these changes
Mar 3, 2025
robintown
reviewed
Mar 4, 2025
Comment on lines
+65
to
+66
| // Allow fs access to local build of wasm | ||
| "../matrix-rust-sdk-crypto-wasm/pkg", |
There was a problem hiding this comment.
Every developer's file system and exact setup of linked packages could look different - for instance, I experience this same problem when I use a linked ../matrix-js-sdk package. I think the following, resolving the symlinks with realpath, would work for us both:
Suggested change
| // Allow fs access to local build of wasm | |
| "../matrix-rust-sdk-crypto-wasm/pkg", | |
| // The crypto WASM module is imported dynamically. Since it's common | |
| // for developers to use a linked copy of matrix-js-sdk or Rust | |
| // crypto (which could reside anywhere on their file system), Vite | |
| // needs to be told to recognize it as a legitimate file access. | |
| await realpath( | |
| "node_modules/matrix-js-sdk/node_modules/@matrix-org/matrix-sdk-crypto-wasm", | |
| ), |
There was a problem hiding this comment.
A complication: that path might not exist if not using a linked copy of matrix-js-sdk. (because the dependency will instead be hoisted to node_modules/@matrix-org/matrix-sdk-crypto-wasm)
I don't believe matrix-js-sdk tries to have any documentation today on how to use it with specific bundlers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick vite config to support running a local build of the crypto-wasm library.