Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New device verification popup appears whilst your signing-in device is still syncing #15877

Closed
lampholder opened this issue Dec 1, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5727
Labels
A-E2EE-Cross-Signing T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@lampholder
Copy link
Member

If you have a decent-sized account syncing takes a long time, waiting all that time to verify your new sign in is a pain and feels broken.

Can it wait until this is displayed on the logging in account?
image

@jryans
Copy link
Collaborator

jryans commented Dec 2, 2020

It does sound tricky to do this securely: existing devices could wait until the new device is synced (somehow), but then an evil device could hide itself by evading that mechanism. It would depend how critical we feel it is that you are always toasted for new devices vs. possible only noticing an evil device later on when shields change or you review your device list.

@jryans jryans added A-E2EE-Cross-Signing X-Needs-Product More input needed from the Product team T-Enhancement and removed T-Defect labels Dec 2, 2020
@afranke
Copy link
Contributor

afranke commented Jan 18, 2021

Related to (/duplicate of?) #15673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants