-
-
Notifications
You must be signed in to change notification settings - Fork 827
Conversation
…verify the new login given the chances are that the new login will be stuck doing initial sync, and won't be in position to be verified until its finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it seems like a more reliable workflow, thanks! 😄
I've added a few details we should work out before merging.
…d out by wrapped text elsewhere
@jryans PTAL again |
Adding Design review as well, so they can take a look at these workflow changes before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me code wise, with one tiny cleanup needed. I have added this PR to the Design queue as well.
It will likely to take another day anyway given Design review, but I would suggest we wait until after the RC is cut tomorrow to merge this, so we can have maximal bake time on develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to remove the unnecessary paths. It would be good to merge this in to test more generally and test stability on develop, but @jryans we should park some time Mar 22-24 ahead of the next RC to tweak some of the copy. I'll book something in our calendars as a reminder.
This thread really struck home (I assume it's one of the reasons we lost Canonical), and the fact that we've failed to budget time to iterate and improve the deeply suboptimal cross-signing login flows since launching it at FOSDEM 2020 is very frustrating. So I went on a hack this evening to apply a series of targeted strikes to fix it:
This PR obviously should be split into 7 or so small PRs, but for expediency i've bundled them together here. However, the commits are nicely structured so they can be reviewed one by one.
Depends on matrix-org/matrix-js-sdk#1632
@jryans: I've collected some open issues that I believe are solved by this.
Fixes element-hq/element-web#16252
Fixes element-hq/element-web#15877
Fixes element-hq/element-web#15672
Fixes element-hq/element-web#15429
Fixes element-hq/element-web#13289
Fixes element-hq/element-web#13510