Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device verification with Element-Web #4217

Closed
manuroe opened this issue Apr 14, 2021 · 0 comments · Fixed by #4220
Closed

Fix device verification with Element-Web #4217

manuroe opened this issue Apr 14, 2021 · 0 comments · Fixed by #4220
Assignees
@manuroe
Labels
P1 parity-with-android parity-with-web
Milestone
Sprint - Element ...

Comments

@manuroe
Copy link
Member

manuroe commented Apr 14, 2021

The recent EW rework on verification flow are not compatible with mobile implementation.

Android PR: element-hq/element-android#3140
@manuroe manuroe added this to the Sprint - Element 1.3.2 milestone Apr 14, 2021
@manuroe manuroe self-assigned this Apr 14, 2021
manuroe added a commit that referenced this issue Apr 14, 2021
@manuroe
Self-verification: Fix compatibility with Element-Web when logging in…
2200b2b 
… on iOS

#4217

Just after login, send request instead of waiting for an incoming one as per recent EW changes
manuroe added a commit that referenced this issue Apr 14, 2021
@manuroe
Self-verification: Fix compatibility with Element-Web when logging in…
c28a991 
… on web

#4217

If web triggers a verification request (because the users clicked on "Use another login"), remove the newSignIn alert dialog before display the incoming verification request.
@manuroe manuroe mentioned this issue Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
P1 parity-with-android parity-with-web
Projects
None yet
Milestone
Sprint - Element 1.3.5
Development

Successfully merging a pull request may close this issue.

Self-verification: Fix compatibility with Element-Web element-hq/element-ios
1 participant
@manuroe