Self-verification: Fix compatibility with Element-Web #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New sign-in from iOS: signinFromIOS2.mov |
|
New sign-in from web: signinFromWeb.mov |
| @@ -3955,7 +3975,7 @@ - (void)presentNewKeyVerificationRequestAlertForSession:(MXSession*)session | |||
| } | |||
| }; | |||
|
|
|||
|
|
|||
| /// ooo | |||
There was a problem hiding this comment.
To update or remove ?
| @@ -4093,6 +4113,7 @@ - (void)presentNewSignInAlertForDevice:(MXDevice*)device inSession:(MXSession*)s | |||
|
|
|||
| [self presentViewController:alert animated:YES completion:nil]; | |||
|
|
|||
| //// ooo | |||
There was a problem hiding this comment.
To update or remove ?
manuroe
commented
Apr 15, 2021
manuroe
commented
Apr 15, 2021
SBiOSoftWhare
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4217
The change is similar as for EA: element-hq/element-android#3140. We had the same failures as android.
It just makes the flow work. UX and even wording need more work but we need to fix all platform.
Tests in both direction