Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element Call infinite loop on call start in strict mode #29196

Closed
toger5 opened this issue Feb 5, 2025 · 2 comments · Fixed by #29254
Closed

Element Call infinite loop on call start in strict mode #29196

toger5 opened this issue Feb 5, 2025 · 2 comments · Fixed by #29254
Assignees
@robintown
Labels
A-Developer-Experience A-Element-Call Group calls via Element Call O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@toger5
Copy link
Contributor

toger5 commented Feb 5, 2025 •
edited
Loading

When starting an element call with StrictMode is enabled, we end up in an infinite create/delete loop of the Call object.
This make the UI flicker and prohibits testing/working on embedded element calls with dev builds.
@toger5 toger5 self-assigned this Feb 5, 2025
@dosubot dosubot bot added A-Element-Call Group calls via Element Call O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect labels Feb 5, 2025
@toger5 toger5 removed the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Feb 5, 2025
@toger5 toger5 mentioned this issue Feb 6, 2025
Closed
4 tasks
@dbkr
Copy link
Member

dbkr commented Feb 10, 2025

I think you forgot to write a description for this one ;)

@robintown robintown mentioned this issue Feb 13, 2025
Merged
@robintown robintown assigned robintown and unassigned toger5 Feb 17, 2025
@robintown robintown added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Developer-Experience labels Feb 24, 2025
@fkwp
Copy link
Contributor

fkwp commented Feb 26, 2025

will be fixed by #29254

robintown added a commit to element-hq/element-call that referenced this issue Mar 4, 2025
@robintown
Patch for v0.7: Send a 'close' action when the widget is ready to close
05c079e 
This is a watered-down version of the changes in 832a5aa which should be suitable as a patch to the v0.7 release series. It makes Element Call widgets send a 'close' action in addition to the original 'hangup' action, and nothing more.

The point is that we can then deploy this change to call.element.io with little effort so that clients are more immediately free to expect a 'close' action from Element Call (and thus we unblock #2955 and element-hq/element-web#29196).
This was referenced Mar 4, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robintown robintown

Labels
A-Developer-Experience A-Element-Call Group calls via Element Call O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
4 participants
@dbkr @fkwp @toger5 @robintown