-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room details: use member counts provided by rust instead of counting members ourselves #505
Comments
@alfogrillo does this also need changing on iOS? |
It depends on the UX we want. Currently: iOS is loading the members on the room's details as Android is doing. If we change it as the proposal above, a loader will spin before (or after) the navigation to the members list until the members are ready. Wdyt @csmith? |
On Android it turns out we already allow the user to click on "Members" while it's still loading (and showing the spinner), and they navigate to an empty members list with a spinner overlayed. So with this change we'd show a number instead of a spinner on the details page, but the behaviour wouldn't actually be any different.
There's |
Ok, this is different on iOS, we probably should align to Android somehow.
Also this is different on iOS, we are just waiting all the members to check the power levels. |
For the room details screen, use the member count as supplied by matrix instead of waiting for the entire member list to be retrieved and then manually adding up all the relevant users. This removes the loading state of the member count, relying on a spinner on the member list itself if the user actually wants to see the members. (The performance of that will be improved separately on the rust side in the future) Closes #505
Created a similar issue for iOS here |
Use member count instead of counting members For the room details screen, use the member count as supplied by matrix instead of waiting for the entire member list to be retrieved and then manually adding up all the relevant users. This removes the loading state of the member count, relying on a spinner on the member list itself if the user actually wants to see the members. (The performance of that will be improved separately on the rust side in the future) Closes #505
Use member count instead of counting members For the room details screen, use the member count as supplied by matrix instead of waiting for the entire member list to be retrieved and then manually adding up all the relevant users. This removes the loading state of the member count, relying on a spinner on the member list itself if the user actually wants to see the members. (The performance of that will be improved separately on the rust side in the future) Closes #505
Currently to show the number of users in a room we wait for all the users to be synced, and then count them.
However, Matrix provides the number of users joined and invited to a room as part of the room metadata. The rust SDK bindings expose this as
joinedMembersCount()
andinvitedMembersCount()
onRoom
(but we don't currently use them on Android).We should switch to using those, which will increase the performance of at least part of the room details screen.
The text was updated successfully, but these errors were encountered: