Refactoring the ruby code #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashant-shekhar
force-pushed
the
refactoring-the-ruby-code
branch
from
21a6840 to
ca9cb31
Compare
shireeshj
reviewed
Jan 15, 2021
| user = User.find(params[:userid]) | ||
| emails = user.emails | ||
| render json: emails | ||
| emails = @logged_in_user.emails |
There was a problem hiding this comment.
Where did @logged_in_user variable come from? where is it defined?
shireeshj
reviewed
Jan 15, 2021
| @@ -1,17 +1,22 @@ | |||
| class Api::V1::UploadsController < ApplicationController | |||
| def index | |||
| user = User.find(params[:userid]) | |||
There was a problem hiding this comment.
what if the user record does not exist and you get a RecordNotFound exception? where are you handling it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Concerns to clean the Application Controller.
Solved Issue Refactor the Attachment Model. #9
Added User Authorization
> Solved Issue : User Authorization. #8
Added listing for generated CSV files in a table with File name, Download Option and Generated Date.
> Solved Issues : Add scrollbar! #13 Listing of Bulk Upload #7 Download-Button to upload-button #14