feat: add byteshumanreadable(bytes, num_digits) to expressions #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOD-101
reviewed
Feb 25, 2025
crates/simplexpr/src/eval.rs
Outdated
| let mut size = size.as_f64()?; | ||
| let digits = if size > 0.0 { digits.as_i32()? } else { 0 }; | ||
| let mut suffix = "B"; | ||
| while size >= 1024.0 { |
There was a problem hiding this comment.
If this is added, it would be good to allow users to choose between binary and decimal prefixes: https://en.wikipedia.org/wiki/Byte#Multiple-byte_units and adjust the code accordingly.
There was a problem hiding this comment.
I can add that. Maybe with an optional argument binary/decimal?
bkueng
force-pushed
the
byteshumanreadable
branch
from
f427aaa to
a7f9b74
Compare
DOD-101
reviewed
Mar 2, 2025
| while size >= base { | ||
| match suffix { | ||
| "B" => { | ||
| suffix = "KB"; |
There was a problem hiding this comment.
The suffixes should also be adjusted accordingly.
Also, it might be better to not do this using a loop (just thinking in terms of performance). I would use an ordered array of suffixes and just index into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can be used to display bytes, e.g. free disk space
${byteshumanreadable(EWW_DISK["/"].free,1)}->150.3 GB.Or also for rates, e.g.
${byteshumanreadable(EWW_NET.wlp3s0.NET_DOWN,0)}/s->392 KB/sThe name is a bit long, but I could not think of anything better.
Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing