feat: add a way to dinamically only change GTK CSS configuration. #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h "__" I thought for a method of ignoring changes from certain config files that doesnt involve symlinks, like changing a lot of strings on the filename, adding another config file, or straight up only reloading css if only .(s)css config files changed (which may end up confusing as there is not a way to dinamically change window size if some css code changes it, so i think reloading all unless the user specifies it is the way to go).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a flag to only Reload the GTK CSS code:
The
--onlycssflag will skip the parsing of any eww or yuck config, and only reload the scss config (It was practically already done).Also adding a feature to not monitor any file which ends their filename with "__", to allow an easy way to "enable" this feature.
Additional Notes
Basically, in case a file of '.scss' or '.css' is not on the config folder (symlinked), or their filename ends with "__", they are not going to be watched or monitored for any changes, allowing for scripting, mostly done with the purpose of using pywal and i3 without the hassle of reserving areas so the layout doesn't flick on eww recreating windows, wasting cpu on reacreating and recalling all the scripts, etc.
I think a better method could be thought (instead of using the "__" at the end of filenames to ignore them), so i will gladly modify it if another method is more convenient or intuitive.
Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing