fix memory leak for issue #47 #104
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSancha
reviewed
Sep 19, 2019
Sources/LogReceptacle.swift
Outdated
| acceptDispatcher { | ||
| if self.doesLogEntry(entry, passFilters: config.filters) { | ||
| acceptDispatcher { [weak self] in | ||
| if self?.doesLogEntry(entry, passFilters: config.filters) ?? false { |
There was a problem hiding this comment.
Thanks for finding this! I would use
[weak self] in
guard let self = self else { return }
That way you don't have to deal with optionals
EdSancha
reviewed
Sep 25, 2019
There was a problem hiding this comment.
Could you still rename the variable this to be self After the guard it's alright to keep the name and it's also a standard, in fact, @emaloney initiated this change and was included in Swift 4.2 https://github.com/apple/swift-evolution/blob/master/proposals/0079-upgrade-self-from-weak-to-strong.md
Thank you!
EdSancha
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weak self to avoid retaining loop, for fixing memory leak for issue #47