Switch to pnpm + vitest (away from yarn @ 1 and jest) #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
NullVoxPopuli
force-pushed
the
switch-to-pnpm
branch
2 times, most recently
from
dca0bed to
96ef8ae
Compare
eh update lockfile eh eh
NullVoxPopuli
force-pushed
the
switch-to-pnpm
branch
from
96ef8ae to
55571e2
Compare
| @@ -119,7 +103,9 @@ | |||
| "release-it": "^17.0.0", | |||
| "sort-package-json": "^2.6.0", | |||
| "typescript": "^5.2.2", | |||
| "typescript-eslint": "^8.7.0" | |||
| "typescript-eslint": "^8.7.0", | |||
| "vite": "^5.4.9", | |||
There was a problem hiding this comment.
@NullVoxPopuli is this intentionally added? Why would we need it?
There was a problem hiding this comment.
yea, we import from vite in the vitest.config
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 |
There was a problem hiding this comment.
@NullVoxPopuli can/should we explicitly set the version? just thinking that it won't drift some day to v10 once it released plus it's explicit
There was a problem hiding this comment.
it uses the packageManager field
| "engines": { | ||
| "node": "18.* || 20.* || >= 21" | ||
| }, | ||
| "volta": { |
There was a problem hiding this comment.
@NullVoxPopuli maybe e could keep volta config but pin pnpm using it?
SergeAstapov
approved these changes
Oct 23, 2024
SergeAstapov
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm is a strict package manager, and yarn can't be trusted.
Some tooling we want to use doesn't support yarn (release-plan, fixturify-project / scenario-tester, etc).
I needed to include a vitest switch in here, because I needed to debug some failures when I switch to pnpm, and jest in just bad at debugging (no integration with the debug terminal in vscode)
It's way faster to switch to vitest (done in < 1 minute) than to fix jest.
Additionally, it looks like there was a failing situation with the no-get rule. So that's been fixed here: 55571e2