Make edition=octane and update deps for Ember v4 compatibility #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
requested changes
Jan 12, 2022
There was a problem hiding this comment.
I don't know what the changes need to be to make this ready to merge but we need to think just a tiny bit more deeply about it and make sure we're doing the right thing. I tried to explain myself in a comment but I fear that I haven't been clear enough and this is a bit of a nuanced problem 🙃
This is due to ember-cli/ember-welcome-page#385 which breaks `ember new`
|
@mansona CI now green with latest Ember.js version! Commits history may point to all the problems I faced. |
mansona
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes CI green again.