-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP-better unload records fixes #3296 #3301
Conversation
@@ -173,8 +181,63 @@ InternalModel.prototype = { | |||
return this.record; | |||
}, | |||
|
|||
directlyRelatedRecords: function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe s/record/internalModel ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please PR to this branch
Fixes #3296 |
@igorT is this still the approach you had in mind? |
@igorT do you have some time to write up what needs to happen before this pr can be merged? |
@igorT do you have some time to write up what needs to happen before this pr can be merged? |
I'm going to close this issue since there hasn't been any response in a while. Feel free to reopen if there is an update. |
@igorT rebased at https://github.com/hjdivad/data/tree/better-unload I'll try to find some time to finish this |
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Includes work from @igorT and @sly7-7 [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Finally - Add a lot of `toString`s to test classes, as a debugging convenience. - Minor test cleanup Includes work from @igorT, @sly7-7 and @pangratz [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Finally - Add a lot of `toString`s to test classes, as a debugging convenience. - Minor test cleanup Includes work from @igorT, @sly7-7 and @pangratz [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Finally - Add a lot of `toString`s to test classes, as a debugging convenience. - Minor test cleanup Includes work from @igorT, @sly7-7 and @pangratz [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Finally - Add a lot of `toString`s to test classes, as a debugging convenience. - Minor test cleanup Includes work from @igorT, @sly7-7 and @pangratz [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Finally - Add a lot of `toString`s to test classes, as a debugging convenience. - Minor test cleanup Includes work from @igorT, @sly7-7 and @pangratz [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Finally - Add a lot of `toString`s to test classes, as a debugging convenience. - Minor test cleanup Includes work from @igorT, @sly7-7 and @pangratz [Fix emberjs#3296] [Supercede emberjs#3301]
`internalModel`s need to stay around as long as they're connected to a live record via relationships. Once an entire subgraph is removed however, we can free all of it. Also add a couple of "late private" fields to `internalModel`'s constructor for shape preservation. Finally - Add a lot of `toString`s to test classes, as a debugging convenience. - Minor test cleanup Includes work from @igorT, @sly7-7 and @pangratz [Fix emberjs#3296] [Supercede emberjs#3301]
@sly7-7