Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP-better unload records fixes #3296 #3301

Closed
wants to merge 3 commits into from
Closed

WIP-better unload records fixes #3296 #3301

wants to merge 3 commits into from

Conversation

igorT
Copy link
Member

@igorT igorT commented Jun 11, 2015

sly7-7
sly7-7 reviewed Jun 11, 2015
View reviewed changes
packages/ember-data/lib/system/model/internal-model.js
@@ -173,8 +181,63 @@ InternalModel.prototype = {
return this.record;
},

directlyRelatedRecords: function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe s/record/internalModel ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please PR to this branch

@igorT
Copy link
Member Author

igorT commented Jun 11, 2015

Fixes #3296

@sly7-7 sly7-7 mentioned this pull request Jan 7, 2016
Closed
@raytiley
Copy link

@igorT is this still the approach you had in mind?

@bmac
Copy link
Member

bmac commented Mar 27, 2016

@igorT do you have some time to write up what needs to happen before this pr can be merged?

@tchak tchak mentioned this pull request May 24, 2016
Merged
@bmac
Copy link
Member

bmac commented Jun 24, 2016

@igorT do you have some time to write up what needs to happen before this pr can be merged?

@bmac
Copy link
Member

bmac commented Jul 11, 2016

I'm going to close this issue since there hasn't been any response in a while. Feel free to reopen if there is an update.

@bmac bmac closed this Jul 11, 2016
@hjdivad
Copy link
Member

hjdivad commented Oct 3, 2016

@igorT rebased at https://github.com/hjdivad/data/tree/better-unload

I'll try to find some time to finish this

hjdivad added a commit to hjdivad/data that referenced this pull request Oct 19, 2016
@hjdivad
Free up internalModels
18e7254 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
@hjdivad hjdivad mentioned this pull request Oct 19, 2016
Merged
hjdivad added a commit to hjdivad/data that referenced this pull request Oct 19, 2016
@hjdivad
Free up internalModels
75c1a75 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Oct 19, 2016
@hjdivad
Free up internalModels
918b88d 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Oct 21, 2016
@hjdivad
Free up internalModels
2872536 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Oct 22, 2016
@hjdivad
Free up internalModels
53a22c2 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Oct 22, 2016
@hjdivad
Free up internalModels
d701ce0 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Oct 22, 2016
@hjdivad
Free up internalModels
484909c 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Oct 22, 2016
@hjdivad
Free up internalModels
c2f3d8a 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Oct 22, 2016
@hjdivad
Free up internalModels
7bd94eb 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Includes work from @igorT and @sly7-7

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Jan 15, 2017
@hjdivad
Free up internalModels
700fe90 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Finally
  - Add a lot of `toString`s to test classes, as a debugging convenience.
  - Minor test cleanup

Includes work from @igorT, @sly7-7 and @pangratz

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Jan 15, 2017
@hjdivad
Free up internalModels
c5f22fb 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Finally
  - Add a lot of `toString`s to test classes, as a debugging convenience.
  - Minor test cleanup

Includes work from @igorT, @sly7-7 and @pangratz

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Jan 15, 2017
@hjdivad
Free up internalModels
fd8d42b 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Finally
  - Add a lot of `toString`s to test classes, as a debugging convenience.
  - Minor test cleanup

Includes work from @igorT, @sly7-7 and @pangratz

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Jan 16, 2017
@hjdivad
Free up internalModels
eb71a9e 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Finally
  - Add a lot of `toString`s to test classes, as a debugging convenience.
  - Minor test cleanup

Includes work from @igorT, @sly7-7 and @pangratz

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Jan 16, 2017
@hjdivad
Free up internalModels
fddb4cb 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Finally
  - Add a lot of `toString`s to test classes, as a debugging convenience.
  - Minor test cleanup

Includes work from @igorT, @sly7-7 and @pangratz

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Jan 16, 2017
@hjdivad
Free up internalModels
b387340 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Finally
  - Add a lot of `toString`s to test classes, as a debugging convenience.
  - Minor test cleanup

Includes work from @igorT, @sly7-7 and @pangratz

[Fix emberjs#3296]
[Supercede emberjs#3301]
hjdivad added a commit to hjdivad/data that referenced this pull request Jan 16, 2017
@hjdivad
Free up internalModels
2f18405 
`internalModel`s need to stay around as long as they're connected to a live
record via relationships.  Once an entire subgraph is removed however, we can
free all of it.

Also add a couple of "late private" fields to `internalModel`'s constructor for
shape preservation.

Finally
  - Add a lot of `toString`s to test classes, as a debugging convenience.
  - Minor test cleanup

Includes work from @igorT, @sly7-7 and @pangratz

[Fix emberjs#3296]
[Supercede emberjs#3301]
@stefanpenner stefanpenner deleted the better-unload branch April 18, 2017 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@igorT @raytiley @bmac @hjdivad @sly7-7