Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance app documentation #6949

Merged
merged 3 commits into from Jan 10, 2020
Merged

improve performance app documentation #6949

merged 3 commits into from Jan 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 6, 2020

I removed php server recommendation since we can use ember-cli's
server.

Is there a specific reason we pin tracerbench to 2.3?

/cc @skaterdav85 @runspired

I removed `php` server recommendation since we can use ember-cli's
server.
@ghost
Copy link
Author

ghost commented Jan 6, 2020

For my curiosity as well, why are we using port 500? I assume other parts of the perf script rely upon that? If it isn't a hard requirement I would update the ember serve command to find an available port automatically.

We don't want to measure the performance of live-reload assets.
@runspired
Copy link
Contributor

RE tracerbench version I'm not sure there is a reason to pin. RE port not sure there's a reason for that either. Feel free to update both if it simplifies things.

@runspired runspired merged commit f047b84 into emberjs:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants