Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore inital checkout when running perf analysis #6955

Merged
merged 1 commit into from Jan 10, 2020
Merged

restore inital checkout when running perf analysis #6955

merged 1 commit into from Jan 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2020

This ensures we checkout whatever branch the user had when they launched the script.
Further improvements would be to bail if there are staged changes since they could violate the principles of reproducible measurements. I'm waiting to do those since we are considering migrating this script to JS for consistency.

@runspired runspired merged commit 7ea3d45 into emberjs:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants