Async Example for acceptance-test

[olivierlesnicki]

On the README.md it is stated that:

If an error is thrown in your promise or a promise within test becomes rejected, ember-qunit will fail the test. To assert that a promise should be rejected, you can "catch" the error and assert that you got there:

test('sometimes async gets rejected', function(assert){
  assert.expect(1);
  var myThing = MyThing.create()

  return myThing.exampleMethod().then(function(){
    assert.ok(false, "promise should not be fulfilled");
  })['catch'](function(err){
    assert.equal(err.message, "User not Authorized");
  });
});

While this works well for unit tests, I'm unable to find an equivalent workaround for acceptance test. I'd like to test scenarios in which my server calls fail (400, 500, etc..). But the error is always thrown and ember-qunit fail.

[olivierlesnicki]

See following gist:
https://gist.github.com/olivierlesnicki/8478a6ae7379ada0d6e5

[olivierlesnicki]

Our team member was able to workaround the issue by using:

    request.then(() => {}, (err) => {
      if (err.status === 400) {
        this.set('showErrorMessage', true);
      } else {
        throw error;
      }
    });

instead of

    request.catch((err) => {
      if (err.status === 400) {
        this.set('showErrorMessage', true);
      } else {
        throw error;
      }
    });

Does ember-qunit fail before the catch for rejected promises?

[olivierlesnicki]

It seems ember-qunit fails whenever an error is not handled within the first .then()

rejectedPromise
  .then(successCallback, errorCallback)
  // the test doesn't fail

rejectedPromise
  .then(successCallback)
  // the test fails although the rejected promise has been handled
  .then(successCallback, errorCallback)

rejectedPromise
  .then(successCallback)
  // the test fails although the rejected promise has been handled
  .catch(errorCallback)

[voltidev]

@olivierlesnicki You can try to rewrite the original Ember.Test.adapter.exception like this:

/* jshint ignore:start */
import Ember from 'ember';
import { module, test } from 'qunit';
import startApp from 'payment-widget/tests/helpers/start-app';

let adapterException;

module('Acceptance | amount | server errors', {
  beforeEach() {
    this.application = startApp();

    // Ignore promise rejection.
    // Original exception will fail test on promise rejection.
    adapterException = Ember.Test.adapter.exception;
    Ember.Test.adapter.exception = () => null;
  },

  afterEach() {
    Ember.Test.adapter.exception = adapterException;
    Ember.run(this.application, 'destroy');
  }
});

test('visiting /:receiverId with invalid receiverId', async (assert) => {
  server.get('/payment-receivers/:id', null, 404);
  await visit(`/123`);
  assert.equal(currentRouteName(), 'not-found', 'it redirects to not-found route on 404 status');

  server.get('/payment-receivers/:id', null, 500);
  await visit(`/123`);
  assert.equal(currentRouteName(), 'error', 'it redirects to error route on 500 status');
});

If you'd like to hide console log errors you could also rewrite Ember.Logger.error the same way:

  beforeEach() {
    this.application = startApp();

    adapterException = Ember.Test.adapter.exception;
    emberLoggerError = Ember.Logger.error;

    Ember.Test.adapter.exception = () => null;
    Ember.Logger.error = () => null;
  },

  afterEach() {
    Ember.Test.adapter.exception = adapterException;
    Ember.Logger.error = emberLoggerError;

    Ember.run(this.application, 'destroy');
  }

[jonathansamines]

I am also experiencing the same trouble when trying to test "error" states conditions. The weird part is that my tests are only failing on [email protected] although the adapter has not changed since 1.13.x (or before) as you can see here. I´m still trying to figure out what is going on, although temporary replacing the Ember.Test.adapter.exception function has worked pretty well.

[Turbo87]

closing this issue, as it should be resolved by the new testing APIs