Expose skip in ember-qunit

[olivierlesnicki]

No description provided.

[rwjblue]

import { skip } from 'qunit'; will give you skip

[olivierlesnicki]

By default ember-cli generator uses import { test } from ember-qunit. I'll this raise it against ember-cli to make sure the same qunit is imported on all blueprints be it qunit or ember-qunit.

[pangratz]

@olivierlesnicki be aware though that import { test } from 'ember-qunit' and import { test } from 'qunit' don't import the same test, as the ember-qunit one adds an assertion for failed promises.

[olivierlesnicki]

@pangratz Ah! This is not obvious for a new user. ember-cli blueprints sometimes generate test that import test from qunit (e.g. controller-test), sometimes test that import test from ember-qunit (e.g. acceptance-test)

[olivierlesnicki]

@pangratz @rwjblue - the behavior of test from q-unit could actually be the reason for an other issue I've raised: https://github.com/rwjblue/ember-qunit/issues/163

[trentmwillis]

Hate to revive an old thread, but I'd like to see skip added as an export in ember-qunit as well. I don't think it makes much sense to force two different import statements on devs (one for moduleFor, test and another for skip). Additionally, I've seen several developers try to debug why skip wasn't working after attempting to import it from ember-qunit. I'll gladly open a new PR if this makes sense.

cc @nickiaconis

[rwjblue]

@trentmwillis - Adding a skip and module export to ember-qunit that does throw new Error('Please import skip from qunit'); should provide enough guidance to folks that accidentally use the wrong one...