Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen test-waiters range #1524

Merged
merged 11 commits into from
Jan 30, 2025

Conversation

NullVoxPopuli
Copy link
Collaborator

test-waiters v4 has been released, so let's allow it to be installed

@boris-petrov
Copy link

When is this coming? 😄

@NullVoxPopuli
Copy link
Collaborator Author

I or someone needs to figure out what's going on with the tests <3

@NullVoxPopuli NullVoxPopuli force-pushed the widen-test-waiters-range branch from 05f4708 to a40b41a Compare January 30, 2025 17:51
@NullVoxPopuli NullVoxPopuli merged commit e9045ab into emberjs:master Jan 30, 2025
23 checks passed
@NullVoxPopuli NullVoxPopuli deleted the widen-test-waiters-range branch January 30, 2025 20:59
@github-actions github-actions bot mentioned this pull request Jan 30, 2025
NullVoxPopuli added a commit that referenced this pull request Jan 30, 2025
* Widen test-waiters range

* Add try scenario

* Re-roll lockfile. Don't lie about the test-app's expected node version

* Force re-sync

* What about an override?

* Revert "What about an override?"

This reverts commit f9ca7dd.

* A test needed to be updated

* Add @embroider/macros to the test-app

* Reduce lockfile changes

* Revert "Force re-sync"

This reverts commit 063919b.

* Only the floating test needs the -f
NullVoxPopuli added a commit that referenced this pull request Jan 30, 2025
* Widen test-waiters range (#1524)

* Widen test-waiters range

* Add try scenario

* Re-roll lockfile. Don't lie about the test-app's expected node version

* Force re-sync

* What about an override?

* Revert "What about an override?"

This reverts commit f9ca7dd.

* A test needed to be updated

* Add @embroider/macros to the test-app

* Reduce lockfile changes

* Revert "Force re-sync"

This reverts commit 063919b.

* Only the floating test needs the -f

* bump ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants