Widen test-waiters range #1524
Merged
Widen test-waiters range #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
widen-test-waiters-range
branch
from
9a5c1d7 to
e31b2ed
Compare
NullVoxPopuli
force-pushed
the
widen-test-waiters-range
branch
from
e31b2ed to
05f4708
Compare
|
When is this coming? 😄 |
|
I or someone needs to figure out what's going on with the tests <3 |
NullVoxPopuli
force-pushed
the
widen-test-waiters-range
branch
from
05f4708 to
a40b41a
Compare
kategengler
approved these changes
Jan 30, 2025
Merged
NullVoxPopuli
added a commit
that referenced
this pull request
Jan 30, 2025
* Widen test-waiters range * Add try scenario * Re-roll lockfile. Don't lie about the test-app's expected node version * Force re-sync * What about an override? * Revert "What about an override?" This reverts commit f9ca7dd. * A test needed to be updated * Add @embroider/macros to the test-app * Reduce lockfile changes * Revert "Force re-sync" This reverts commit 063919b. * Only the floating test needs the -f
NullVoxPopuli
added a commit
that referenced
this pull request
Jan 30, 2025
* Widen test-waiters range (#1524) * Widen test-waiters range * Add try scenario * Re-roll lockfile. Don't lie about the test-app's expected node version * Force re-sync * What about an override? * Revert "What about an override?" This reverts commit f9ca7dd. * A test needed to be updated * Add @embroider/macros to the test-app * Reduce lockfile changes * Revert "Force re-sync" This reverts commit 063919b. * Only the floating test needs the -f * bump ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-waiters v4 has been released, so let's allow it to be installed