Fix missing hostWhitelist in FastBoot's package.json manifest #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds accessing `request.host` to `fastboot-app` that reproduces the missing FastBoot package.json data (here `hostWhitelist`) reported in embroider-build#160.
simonihmig
changed the title
|
I was hitting the same problem. This fix works for me. |
|
Thanks, nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds accessing
request.hosttofastboot-appthat reproduces the missing FastBoot package.json data (herehostWhitelist)reported in #160. This triggers theYou must provide a hostWhitelist to retrieve the hosterror making the app's FastBoot tests fail.The second commit adds a fix, exposing the
hostWhitelistmanifest field, that got lost in the custom compat adapter, but still seems to be required and expected byfastBoothere.