-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acquisition function builder #490
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Scienfitz: definitely curious about your feedback. I think the current draft is already substantially clearer and less error-prone that what we had before. The way I went about this is to think about the main pain points and see what architecture could solve them all, that's how I ended up with the design. However, there might still be parts that can be done in a very different/better way, or perhaps there is an even cleverer design to start with. Let me hear your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has the potential to break things badly, hence it would be a great use case for applying the benchmarks comparisons
if not, at the very least we need to check 2-3 curve or example whether they've changed. Whata bout directi arylation, michaelewicz and bandit to cover several distinct things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this one can have huge implications. The hope is that this is more or less the last time that we need to worry as much about breaking things as we did in the past. But yes, we should definitely run some examples before we merge, ideally both of us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine, as discussed in chat
86b2462
to
f49ced0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I def support the idea of this, do you want to move it to production?
ccdc654
to
583aa06
Compare
This PR refactors the translation of BayBE acquisition functions into BoTorch acquisition functions, adopting concepts from the builder software pattern.
Rationale / Goals / Problems Addressed:
BotorchAcquisitionArgs
class