Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: liquid 18 #2

Merged
merged 10 commits into from
Jan 16, 2025
Merged

feat!: liquid 18 #2

merged 10 commits into from
Jan 16, 2025

Conversation

ElectricCookie
Copy link
Collaborator

@ElectricCookie ElectricCookie commented Jan 16, 2025 •
edited
Loading

Summary

Updates the liquid flutter package to version 18.2.0 bringing the new branding and modal changes

  • This is a breaking changes due to some APIs being handled differently (Modals are now using the navigator and require some different handling)
  • This is also a visual breaking change because the default theme of liquid_flutter is no longer using the emd visual tokens

Checklist

  • You agree with our CLA
  • Included tests (or is not applicable).
  • Updated documentation (or is not applicable).

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ElectricCookie ElectricCookie changed the base branch from main to dev January 16, 2025 10:20
@ElectricCookie ElectricCookie marked this pull request as ready for review January 16, 2025 15:12
@ElectricCookie ElectricCookie requested a review from KochC January 16, 2025 15:13
KochC
KochC approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@KochC KochC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ElectricCookie ElectricCookie merged commit 3f8dde0 into dev Jan 16, 2025
4 checks passed
@ElectricCookie ElectricCookie deleted the feat_liquid_18 branch January 16, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KochC KochC KochC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElectricCookie @CLAassistant @KochC