Add label property and autoLabel option for babel-plugin-emotion #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2017 12:53
This should help devs figure out where css code is written or the component that it comes from. This should also open the doors for `name` css property for devs to customize.
Codecov Report
|
added 4 commits
October 4, 2017 13:32
- tries to get the react class - tries to get the HoC parent - legacy behavior
tkh44
commented
Oct 9, 2017
| const parent = path.findParent(p => p.isVariableDeclarator()) | ||
| return parent && t.isIdentifier(parent.node.id) ? parent.node.id.name : '' | ||
| } | ||
|
|
||
| export function getIdentifierName(path, t) { | ||
| const classParent = path.findParent(p => t.isClass(p)) |
There was a problem hiding this comment.
This is so we can include the name of the component the inline css call is in.
emmatown
reviewed
Nov 3, 2017
There was a problem hiding this comment.
I'm mostly cool with this but I'm wondering if we should add a label property instead, like glamor. It wouldn't be very hard to do, people would be able to add the labels manually if they wanted to and the labels could merge so you could see what the styles are composed from.
emmatown
reviewed
Nov 3, 2017
Add label property
|
@mitchellhamilton can you take a look at my updates. The emotion-server updates could use another look. |
emmatown
changed the title
emmatown
approved these changes
Nov 4, 2017
This was referenced Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This should help devs figure out where css code is written or the
component that it comes from. This should also open the doors for
namecss property for devs to customize.Checklist: