Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jest-emotion in certain cases with nested selectors #641

Merged
merged 5 commits into from
May 10, 2018

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented May 4, 2018

What:

Fix jest-emotion with certain cases with nested selectors

Why:

#639

How:

Make it so that the serializer only gets the styles from the classes that are used via the inserted cache rather than getting all the styles and filtering it in a way that causes some styles to be ignored.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@emmatown emmatown requested a review from tkh44 May 4, 2018 09:15
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #641 into master will decrease coverage by 0.22%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/jest-emotion/src/index.js 84.61% <100%> (-7.7%) ⬇️
packages/jest-emotion/src/replace-class-names.js 100% <100%> (ø) ⬆️

@emmatown emmatown merged commit 6d5eb1c into master May 10, 2018
@emmatown emmatown deleted the fix-jest-emotion branch May 10, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant