feat: add uiLang parameter
#714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javieri-empathy
commented
Sep 9, 2022
Comment on lines
+310
to
+312
| if (snippetConfig.lang) { | ||
| snippetConfig.uiLang ??= snippetConfig.lang; | ||
| } |
There was a problem hiding this comment.
The watcher approach, while ideal to have in one place the side effects of mutating the snippet config brought some issues, as you lost the information of which properties where modified, so instead I opted to do a more imperative approach in the only method that had all the information we needed to make a decision.
packages/x-components/src/x-installer/x-installer/x-installer.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-installer/x-installer/x-installer.ts
Outdated
Show resolved
Hide resolved
luismmdev
suggested changes
Sep 13, 2022
There was a problem hiding this comment.
good job! @mnavarroespinosa suggested a change that I think might be interesting to do now. If you don't think so, let me know and I'll approve the pr.
packages/x-components/src/x-installer/x-installer/x-installer.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-installer/x-installer/x-installer.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-installer/x-installer/x-installer.ts
Outdated
Show resolved
Hide resolved
luismmdev
approved these changes
Sep 13, 2022
mnavarroespinosa
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EX-6855
Adds suppport for the
uiLangparamenter. This is an optional paramenter of theSnippetConfig. When no passed it should default tolang.