Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.3 #1521

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Release 4.0.3 #1521

merged 1 commit into from
Feb 7, 2025

Conversation

@emscripten-bot emscripten-bot added the release Used to tag release PRs label Feb 7, 2025
@emscripten-bot emscripten-bot requested a review from a team February 7, 2025 17:51
@emscripten-bot emscripten-bot enabled auto-merge (squash) February 7, 2025 17:51
@sbc100
Copy link
Collaborator

sbc100 commented Feb 7, 2025

@dschuff can we fix the bot so it doesn't create branches called "create-pull-request/patch"? Can we give the branches meaningful names instead? Then I think they won't clobber each other either.

@sbc100 sbc100 disabled auto-merge February 7, 2025 17:59
@sbc100 sbc100 enabled auto-merge (squash) February 7, 2025 17:59
@dschuff
Copy link
Member

dschuff commented Feb 7, 2025

Maybe. there are some options on https://github.com/marketplace/actions/create-pull-request
Do we have the setting to automatically delete branches on merge enabled? (The action can't delete branches on merge itself, because merging doesn't re-trigger the action).

@dschuff
Copy link
Member

dschuff commented Feb 7, 2025

We can change the branch name to whatever, but if not re-using branches is what you want it sounds like what you want is maybe the "alternative strategy" where it always just creates a new branch?

@sbc100 sbc100 merged commit 127ce42 into main Feb 7, 2025
9 checks passed
@sbc100 sbc100 deleted the create-pull-request/patch branch February 7, 2025 18:10
@sbc100
Copy link
Collaborator

sbc100 commented Feb 7, 2025

We can change the branch name to whatever, but if not re-using branches is what you want it sounds like what you want is maybe the "alternative strategy" where it always just creates a new branch?

Can we just call the branch release_X.Y.Z?

@dschuff
Copy link
Member

dschuff commented Feb 7, 2025

Worth a shot: #1522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Used to tag release PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants