Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newlines for new release cycle report #1868

Closed
captn3m0 opened this issue Nov 17, 2022 · 3 comments · Fixed by #2622
Closed

Fix newlines for new release cycle report #1868

captn3m0 opened this issue Nov 17, 2022 · 3 comments · Fixed by #2622
Labels
bug Something isn't working

Comments

@captn3m0
Copy link
Member

Our automation reports new unknown release cycles noticed for any tracked products: #1867 (comment).

It does this via This GitHub Workflow, which leaves a new comment when the dependabot PR is filed, and the latest automation runs.

The code that generates the list of product warnings is here.

It currently generates everything in a single line, due to GitHub limitations, and ease of coding. GitHub now supports a delimiter for newlines, so this needs to be used: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings

Updating the latest.py script should be good enough.

@captn3m0 captn3m0 added the bug Something isn't working label Nov 17, 2022
@marcwrobel
Copy link
Member

Just an idea (you may already had) but it could be great if the bot could open an issue for each product.

The issue could be title [product name] x.y and the body :

A new version has been detected, here is the snippet :

-   releaseCycle: "x.y"
    releaseDate: yyy-mm-dd
    eol: false
    latest: "x.y.z"
    latestReleaseDate: yyy-mm-dd

The YAML would not be complete of course but that would be a good start for anyone willing to contribute to endoflife.date.

@captn3m0
Copy link
Member Author

Yeah, but then it increases burden on the maintainers, since only they can commit to those local branches. Contribution workflows that fix this local branch are not very nice either, and it might get too confusion.

I was considering keeping an always pinned issue that is updated each time it runs, that is more contributor friendly - look here for new releases we need to add.

Still open to trying, but also keep in mind the additional complexity this will bring (keeping a lot of state to remember which PRs are filed etc). We also have a lot of false positives, and it's hard to guess the next release cycle.

@marcwrobel
Copy link
Member

I agree with you on this point : in my mind only an issue would be created, not a PR. And the code snippet would be written in the issue description.

And I also agree with you on the single pinned issue. Always updating the issue description (or adding a new comment to the issue) would be simpler than creating and maintaining an individual issue for each product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants