Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amazon EKS #307

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Amazon EKS #307

merged 2 commits into from
Jul 24, 2021

Conversation

captn3m0
Copy link
Member

@captn3m0 captn3m0 commented Jul 21, 2021 •
edited
Loading

Amazon EKS.

iconSlug seems broken because #307 isn't merged yet. That should get fixed once #307 is merged and this PR is rebased against that. 307 is merged.

@captn3m0 captn3m0 self-assigned this Jul 21, 2021
@captn3m0 captn3m0 mentioned this pull request Jul 21, 2021
Closed
@captn3m0 captn3m0 requested a review from BiNZGi July 22, 2021 11:02
BiNZGi
BiNZGi requested changes Jul 22, 2021
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked all the details on the website, it's all okay.
However the icon is not yet displayed correct.

@captn3m0 captn3m0 changed the title [tools] Adds EKS Amazon EKS Jul 23, 2021
@captn3m0 captn3m0 added the new-product This PR adds a new product to the website. label Jul 23, 2021
@captn3m0 captn3m0 requested a review from BiNZGi July 24, 2021 09:09
BiNZGi
BiNZGi approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked again and now everything is okay, excellent work -> merge

@BiNZGi BiNZGi merged commit 4d0f126 into master Jul 24, 2021
@captn3m0 captn3m0 deleted the eks branch July 28, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiNZGi BiNZGi BiNZGi approved these changes

Assignees

@captn3m0 captn3m0

Labels
new-product This PR adds a new product to the website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captn3m0 @BiNZGi