[products] Show Identifiers in product pages #5356
Conversation
captn3m0
force-pushed
the
show-product-identifiers
branch
from
0cf74e7 to
5828d83
Compare
|
Working on generating links, converting to draft. |
Based on modifications done in #5356.
Looks like it was wrong, see #5356.
Looks like it was wrong, see #5356.
Looks like it was wrong, see #5356.
Based on modifications done in #5356.
Looks like it was wrong, see #5356.
Looks like it was wrong, see #5356.
Looks like it was wrong, see #5356.
|
I'll drop the PURL fix commits and rebase this. A PURL validator will be nice to have. |
@captn3m0, don't mind I am doing it right now. |
marcwrobel
force-pushed
the
show-product-identifiers
branch
2 times, most recently
from
4d0b3ba to
64d66eb
Compare
There was a problem hiding this comment.
Overall LGTM.
Before merging I will:
- add a validator to validate all identifiers
- see if I should exclude the validation of those generated URLs from product-data-validator
- see if I can improve the rendering (having a " Show Product Identifiers" at the bottom seems a bit strange).
|
@marcwrobel you're removing the wrong PURLs (and adding the right ones) and not working on any repology/CPE identifiers, right? not that I do something that you already did, but isn't in the master at the moment 😆 |
Simple version to start with. We can look at a PURL->URL generator later
Yes, that's right. Credit goes to @captn3m0 though ;) |
marcwrobel
force-pushed
the
show-product-identifiers
branch
from
953dcbe to
9ed4720
Compare
- add validation for identifiers in product-data-validator.rb (makes errors easier to read) - simplify and generify identifiers.html (render all identifiers the same way) - make purl-to-url generate URLs for all identifier types (rename to identifier-to-url) - make identifier-to-url more strict for unknown identifier types or variants - revert sass-embedded version to avoid lots of build warnings
marcwrobel
force-pushed
the
show-product-identifiers
branch
from
9ed4720 to
b81ff94
Compare
|
@captn3m0 I improved the PR:
I don't know how to improve the rendering (having a " Show Product Identifiers" at the bottom seems a bit strange), so left it like this. |
|
Merging, will see tomorrow how many broken links this generates. |
Currently, we don't expose identifiers beyond storing them in the front-matter. This will start exposing the identifiers on the website as a start.
Simple version to start with, based on https://github.com/package-url/packageurl-python/blob/main/src/packageurl/contrib/purl2url.py, with a few more types, and no support for "versions", since identifiers won't have that.