Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshal: null should not be accepted in place of Object.prototype #1324

Closed
gibson042 opened this issue Oct 13, 2022 · 0 comments · Fixed by #1328
Closed

marshal: null should not be accepted in place of Object.prototype #1324

gibson042 opened this issue Oct 13, 2022 · 0 comments · Fixed by #1328
Assignees

Comments

@gibson042
Copy link
Contributor

Per #1313 (comment) , a null prototype is not pass-invariant—a marshal–unmarshal round-trip will convert it into Object.prototype. Accordingly, acceptance of a null prototype should be removed from copyRecord until and unless there is a clear need, at which point it should also be added to tagged record/pseudo-promise/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant