Update TypeScript to 4.5 #1043
Merged
Update TypeScript to 4.5 #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2022
mhofman
force-pushed
the
mhofman/ts-45-compatibility
branch
from
0afe04f to
8d7fc1a
Compare
|
Arf apparently this breaks node-12. @kriskowal any advice? |
mhofman
force-pushed
the
mhofman/ts-45-compatibility
branch
from
8d7fc1a to
a327ecb
Compare
|
As discussed in #1046, okay with dropping 12 at this time. |
mhofman
force-pushed
the
mhofman/ts-45-compatibility
branch
from
a327ecb to
4ecf8ab
Compare
mhofman
force-pushed
the
mhofman/ts-45-compatibility
branch
from
4ecf8ab to
2c0bff0
Compare
kriskowal
approved these changes
Feb 2, 2022
mhofman
force-pushed
the
mhofman/ts-45-compatibility
branch
from
2c0bff0 to
71f51fb
Compare
mhofman
force-pushed
the
mhofman/ts-45-compatibility
branch
from
71f51fb to
2bbf300
Compare
Make some types explicit any to prevent inference
mhofman
force-pushed
the
mhofman/ts-45-compatibility
branch
from
2bbf300 to
8513cfb
Compare
kriskowal
approved these changes
Feb 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TS to 4.5 to align with upcoming
agoric-sdkchange (see Agoric/agoric-sdk#4420).Make some types explicit any to prevent inference. Sprinkle some jsdoc here and there.